ALT Linux Team development discussions
 help / color / mirror / Atom feed
From: "Dmitry V. Levin" <ldv@altlinux.org>
To: ALT Linux Devel Mailing List <devel@altlinux.ru>
Subject: Re: [devel] NMU: cdrecord
Date: Mon, 13 Dec 2004 13:49:17 +0300
Message-ID: <20041213104917.GF6127@basalt.office.altlinux.org> (raw)
In-Reply-To: <20041212215603.GA29983@lks.home>

[-- Attachment #1: Type: text/plain, Size: 1925 bytes --]

On Mon, Dec 13, 2004 at 12:56:03AM +0300, Konstantin A. Lepikhov wrote:
> у ldv@ есть желание сделать это в Сизиф/updates?

Нет, это же 2.6-only change:

> --- cdrtools-2.01a37/cdrecord/cdrecord.c~	2004-12-12 20:38:26 +0300
> +++ cdrtools-2.01a37/cdrecord/cdrecord.c	2004-12-12 20:58:26 +0300
> @@ -466,8 +466,10 @@ main(ac, av)
>  	/*
>  	 * XXX Below this point we do not need root privilleges anymore.
>  	 */
> +	/* XXX Quick'n'dirty hack for linux kernel >= 2.6.8.1 compatability 
>  	if (geteuid() != getuid()) {	/* AIX does not like to do this */
>  					/* If we are not root		*/
> +	/*
>  #ifdef	HAVE_SETREUID
>  		if (setreuid(-1, getuid()) < 0)
>  #else
> @@ -479,6 +481,8 @@ main(ac, av)
>  #endif
>  			comerr("Panic cannot set back effective uid.\n");
>  	}
> +	*/
> +	
>  	/*
>  	 * WARNING: We now are no more able to do any privilleged operation
>  	 * unless we have been called by root.
> @@ -983,10 +987,12 @@ if (lverbose > 2)
>  		 * even on OS that do not support getreuid() which is *BSD
>  		 * and SUSv3 only.
>  		 */
> +		/* XXX Quick'n'dirty hack for linux kernel >= 2.6.8.1 compatability
>  		if (oeuid != getuid()) {
>  			if (setreuid(-1, oeuid) < 0)
>  				errmsg("Could set back effective uid.\n");
>  		}
> +		*/
>  #endif
>  		/*
>  		 * fork() here to start the extra process needed for
> @@ -1001,11 +1007,13 @@ if (lverbose > 2)
>  		/*
>  		 * XXX Below this point we never need root privilleges anymore.
>  		 */
> +		/* XXX Quick'n'dirty hack for linux kernel >= 2.6.8.1 compatability
>  		if (geteuid() != getuid()) {	/* AIX does not like to do this */
>  						/* If we are not root		*/
> -			if (setreuid(-1, getuid()) < 0)
> +	/*		if (setreuid(-1, getuid()) < 0)
>  				comerr("Panic cannot set back effective uid.\n");
>  		}
> +	*/
>  #endif
>  	}
>  	if ((*dp->cdr_set_speed_dummy)(scgp, dp, &speed) < 0) {


-- 
ldv

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

  parent reply	other threads:[~2004-12-13 10:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-12 21:56 Konstantin A. Lepikhov
2004-12-12 22:18 ` [devel] " Konstantin A. Lepikhov
2004-12-12 23:05   ` Konstantin A. Lepikhov
2004-12-13 10:49 ` Dmitry V. Levin [this message]
2004-12-13 10:57   ` Konstantin A. Lepikhov
2004-12-13 11:02     ` Dmitry V. Levin
2004-12-13 14:37       ` Konstantin A. Lepikhov
2004-12-13 15:36         ` Sergey Vlasov
2004-12-13 16:48           ` Konstantin A. Lepikhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041213104917.GF6127@basalt.office.altlinux.org \
    --to=ldv@altlinux.org \
    --cc=devel@altlinux.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

ALT Linux Team development discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://lore.altlinux.org/devel/0 devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 devel devel/ http://lore.altlinux.org/devel \
		devel@altlinux.org devel@altlinux.ru devel@lists.altlinux.org devel@lists.altlinux.ru devel@linux.iplabs.ru mandrake-russian@linuxteam.iplabs.ru sisyphus@linuxteam.iplabs.ru
	public-inbox-index devel

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://lore.altlinux.org/org.altlinux.lists.devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git