From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 4 Aug 2003 18:50:26 +0300 From: Alexander Bokovoy To: ALT Devel discussion list Subject: Re: [devel] Re: [ALT Linux 0002810]: mpg123 -Z file eats LOTS of memory Message-ID: <20030804155026.GA12153@sam-solutions.net> Mail-Followup-To: ALT Devel discussion list References: <20030804141835.C8D074806F@lrn.ru> <20030804153601.GF2334@julia.office.altlinux.ru> <20030804154647.GA27421@basalt.office.altlinux.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20030804154647.GA27421@basalt.office.altlinux.org> X-BeenThere: devel@altlinux.ru X-Mailman-Version: 2.1.2 Precedence: list Reply-To: ALT Devel discussion list List-Id: ALT Devel discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Aug 2003 15:50:54 -0000 Archived-At: List-Archive: List-Post: On Mon, Aug 04, 2003 at 07:46:47PM +0400, Dmitry V. Levin wrote: > On Mon, Aug 04, 2003 at 07:36:01PM +0400, Alexey Tourbin wrote: > > On Mon, Aug 04, 2003 at 06:18:35PM +0400, mantis-admin@altlinux.ru wrote: > > > ======================================================================= > > > Summary: mpg123 -Z file eats LOTS of memory > > > Description: > > > in situation where file is not a mp3, e.g. > > > mpg123 -Z ~/.bash_profile > > > > Зафиксил. Ждите новой сборки на этой неделе. Стоит ли включить > > поддержку esound? Когда-то она была, но goldhead её выключил или просто > > разломал (там кривоватый Makefile). > > > > --- mpg123/readers.c~ 2000-10-30 20:12:59 +0000 > > +++ mpg123/readers.c 2003-08-04 15:26:46 +0000 > > @@ -185,6 +185,8 @@ void stream_close(struct reader *rds) > > { > > if (rds->flags & READER_FD_OPENED) > > close(rds->filept); > > + if (rds->backbuf) > > + free(rds->backbuf); > > } > > > > /**************************************** > > if (data) free (data) > - это масло маслянное. > пишите просто > free (data) > - все соответствующие стандарту libc это поддерживают. Solaris < 8 валится. Лучше перестраховаться. -- / Alexander Bokovoy --- Must be getting close to town -- we're hitting more people.