From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ldv@altlinux.org>
Date: Mon, 4 Aug 2003 19:46:47 +0400
From: "Dmitry V. Levin" <ldv@altlinux.org>
To: ALT Devel discussion list <devel@altlinux.ru>
Subject: Re: [devel] Re: [ALT Linux 0002810]: mpg123 -Z file eats LOTS of
	memory
Message-ID: <20030804154647.GA27421@basalt.office.altlinux.org>
Mail-Followup-To: ALT Devel discussion list <devel@altlinux.ru>
References: <20030804141835.C8D074806F@lrn.ru>
	<20030804153601.GF2334@julia.office.altlinux.ru>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="BOKacYhQ+x31HxR3"
Content-Disposition: inline
In-Reply-To: <20030804153601.GF2334@julia.office.altlinux.ru>
X-fingerprint: 9658 398D 181B 1200 8FC5  26B8 F6F8 846B C1E2 3429
X-BeenThere: devel@altlinux.ru
X-Mailman-Version: 2.1.2
Precedence: list
Reply-To: ALT Devel discussion list <devel@altlinux.ru>
List-Id: ALT Devel discussion list  <devel.altlinux.ru>
List-Unsubscribe: <http://altlinux.ru/mailman/listinfo/devel>,
	<mailto:devel-request@altlinux.ru?subject=unsubscribe>
List-Archive: </pipermail/devel>
List-Post: <mailto:devel@altlinux.ru>
List-Help: <mailto:devel-request@altlinux.ru?subject=help>
List-Subscribe: <http://altlinux.ru/mailman/listinfo/devel>,
	<mailto:devel-request@altlinux.ru?subject=subscribe>
X-List-Received-Date: Mon, 04 Aug 2003 15:46:48 -0000
Archived-At: <http://lore.altlinux.org/devel/20030804154647.GA27421@basalt.office.altlinux.org/>
List-Archive: <http://lore.altlinux.org/devel/>
List-Post: <mailto:devel@altlinux.org>


--BOKacYhQ+x31HxR3
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On Mon, Aug 04, 2003 at 07:36:01PM +0400, Alexey Tourbin wrote:
> On Mon, Aug 04, 2003 at 06:18:35PM +0400, mantis-admin@altlinux.ru wrote:
> > =======================================================================
> > Summary:                    mpg123 -Z file eats LOTS of memory
> > Description: 
> > in situation where file is not a mp3, e.g.
> > mpg123 -Z ~/.bash_profile
> 
> Зафиксил.  Ждите новой сборки на этой неделе.  Стоит ли включить
> поддержку esound?  Когда-то она была, но goldhead её выключил или просто
> разломал (там кривоватый Makefile).
> 
> --- mpg123/readers.c~	2000-10-30 20:12:59 +0000
> +++ mpg123/readers.c	2003-08-04 15:26:46 +0000
> @@ -185,6 +185,8 @@ void stream_close(struct reader *rds)
>  {
>      if (rds->flags & READER_FD_OPENED)
>          close(rds->filept);
> +    if (rds->backbuf)
> +	    free(rds->backbuf);
>  }
>  
>  /**************************************** 

if (data) free (data)
- это масло маслянное.
пишите просто
free (data)
- все соответствующие стандарту libc это поддерживают.


-- 
ldv

--BOKacYhQ+x31HxR3
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQE/Ln/n9viEa8HiNCkRAm6lAJ4nMtsuaJY8UfhWp01givLY2UHDPQCdEbcO
G/tCGBnvcYCUgEhk1s0O4yw=
=vM7Z
-----END PGP SIGNATURE-----

--BOKacYhQ+x31HxR3--