From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on sa.local.altlinux.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=unavailable autolearn_force=no version=3.4.1 To: devel@lists.altlinux.org References: <20191210152343.33867-1-darktemplar@altlinux.org> <20191210152343.33867-3-darktemplar@altlinux.org> <20191210224500.GC31774@altlinux.org> From: Aleksei Nikiforov Message-ID: <1235fb34-3f69-3ac8-e357-bff0bf313fec@altlinux.org> Date: Wed, 11 Dec 2019 10:56:36 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20191210224500.GC31774@altlinux.org> Content-Type: text/plain; charset=koi8-r; format=flowed Content-Language: ru Content-Transfer-Encoding: 8bit Subject: Re: [devel] [PATCH for apt 02/38] Use correct types and type specifiers X-BeenThere: devel@lists.altlinux.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: ALT Linux Team development discussions List-Id: ALT Linux Team development discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Dec 2019 07:56:41 -0000 Archived-At: List-Archive: List-Post: 11.12.2019 1:45, Dmitry V. Levin пишет: > On Tue, Dec 10, 2019 at 06:23:07PM +0300, Aleksei Nikiforov wrote: >> Found via cppcheck >> --- >> apt/apt-pkg/contrib/cdromutl.cc | 4 ++-- >> apt/apt-pkg/contrib/strutl.cc | 8 ++++---- >> apt/cmdline/acqprogress.cc | 4 ++-- >> apt/methods/connect.cc | 4 ++-- >> apt/methods/http.cc | 9 +++------ >> apt/methods/http.h | 2 +- >> 6 files changed, 14 insertions(+), 17 deletions(-) > > It would be great if you included the cppcheck diagnostics as well, > you can use the following commit as an example: > https://gitlab.com/strace/strace/commit/2b64854e > > So, should such blankets of text be added for each fixed line? Commit messages would become much bigger than commits themselves in that case for a lot of commits considering multiline messages and one-line fixes. Is it really needed considering fixes are already grouped in commits by type? > > _______________________________________________ > Devel mailing list > Devel@lists.altlinux.org > https://lists.altlinux.org/mailman/listinfo/devel >