From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <darktemplar@altlinux.org>
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on
 sa.local.altlinux.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00
 autolearn=unavailable autolearn_force=no version=3.4.1
To: devel@lists.altlinux.org
References: <20191210152343.33867-1-darktemplar@altlinux.org>
 <20191210152343.33867-2-darktemplar@altlinux.org>
 <CA+qzenkiJHdn4PvXi04PHxMpL0adP8FBYtQ=J_Eefndrgn56zA@mail.gmail.com>
From: Aleksei Nikiforov <darktemplar@altlinux.org>
Message-ID: <1020fee7-831e-5a20-d28c-ee3398688ded@altlinux.org>
Date: Wed, 11 Dec 2019 10:51:03 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <CA+qzenkiJHdn4PvXi04PHxMpL0adP8FBYtQ=J_Eefndrgn56zA@mail.gmail.com>
Content-Type: text/plain; charset=koi8-r; format=flowed
Content-Language: ru
Content-Transfer-Encoding: 8bit
Subject: Re: [devel] [PATCH for apt 01/38] Replace post-increments with
 pre-increments
X-BeenThere: devel@lists.altlinux.org
X-Mailman-Version: 2.1.12
Precedence: list
Reply-To: ALT Linux Team development discussions <devel@lists.altlinux.org>
List-Id: ALT Linux Team development discussions <devel.lists.altlinux.org>
List-Unsubscribe: <https://lists.altlinux.org/mailman/options/devel>,
 <mailto:devel-request@lists.altlinux.org?subject=unsubscribe>
List-Archive: <http://lists.altlinux.org/pipermail/devel>
List-Post: <mailto:devel@lists.altlinux.org>
List-Help: <mailto:devel-request@lists.altlinux.org?subject=help>
List-Subscribe: <https://lists.altlinux.org/mailman/listinfo/devel>,
 <mailto:devel-request@lists.altlinux.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Dec 2019 07:51:09 -0000
Archived-At: <http://lore.altlinux.org/devel/1020fee7-831e-5a20-d28c-ee3398688ded@altlinux.org/>
List-Archive: <http://lore.altlinux.org/devel/>
List-Post: <mailto:devel@altlinux.org>

10.12.2019 21:21, Alexey Tourbin пишет:
> On Tue, Dec 10, 2019 at 6:25 PM Aleksei Nikiforov
> <darktemplar@altlinux.org> wrote:
>> +++ b/apt/apt-pkg/acquire-item.cc
>> @@ -486,7 +486,7 @@ void pkgAcqIndexRel::Done(const string &Message,unsigned long long Size,const st
>>
>>           bool found = false;
>>           for (vector<string>::const_iterator I = Repository->FingerPrint.begin();
>> -             I != Repository->FingerPrint.end(); I++)
>> +             I != Repository->FingerPrint.end(); ++I)
>>           {
>>              // Match fingerprint of Release file
>>              if ((*I) == FingerPrint)
> 
> How does that fix anything? It doesn't! Avoid unnecessary changes,
> only make those beaming with thought.  As Pouchkine wrote, "strashisya
> uchasti bessmyslennykh pevtsov".

You're right, but not the way you think you are :)

In order for this fix to matter, signature of operator++ should be fixed 
as well. Currently it's not a standard, and returns not an object copy 
or reference to object, but returns void. I'll fix it too and this 
change would matter :)

> _______________________________________________
> Devel mailing list
> Devel@lists.altlinux.org
> https://lists.altlinux.org/mailman/listinfo/devel
>