From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on sa.local.altlinux.org X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS autolearn=no autolearn_force=no version=3.4.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1795193128; x=1795797928; darn=lists.altlinux.org; h=in-reply-to:content-disposition:content-type:mime-version :references:mail-followup-to:message-id:subject:to:from:date:sender :from:to:cc:subject:date:message-id:reply-to:content-type; bh=8sqyn6zRlAyXzN43TcwKvpOFhxcY9Y4ODSQcwdo9l+g=; b=ZvPc5dvJiI6jMBv0uKiklKr2eY814P6gtEizY3stmK31zDDXtCoUxUUkUW59DsRo+n NHIxJ1GJzy0L0WUgJ7Yy48mgXDkrNEBqDCBo2wDwDBJrg8ZY1HxbU4zahqJSZ1TuS+Zx TkF3Hw/z++6EDMnlZJKrUzqbDCl9kkxC8ccOSEZE+0DBQefwhwCpCQTVt7JKYcx50Jdn 1LybPUHqTO0CgbokvnBEwKQhnKq6NF78+m9OQymSouplDFkXOoNYtG+Jb10+2f7ABdxa zG8qOGzGAM8brkT/mt1t7tYciUE0w1WcGflpkOkwglGRwHzllIADSVjt2FsYvT36zPRp nmdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795193128; x=1795797928; h=in-reply-to:content-disposition:content-type:mime-version :references:mail-followup-to:message-id:subject:to:from:date:sender :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=8sqyn6zRlAyXzN43TcwKvpOFhxcY9Y4ODSQcwdo9l+g=; b=y/2qwZh7+X5TSemOYiM7RueM4rWR8m6xm1yZD16IVV//WtHJoWWPT8arZ8GETWKAZh xF+zp1VJykbeUeuTZiD0ffEs4bWVuREs2iM+OR2OXwJt+1hyFKv0BKqlvuwODiD2Qqrt MASDoLJgJDoOuoIt5ZNelAHns8ZpMIrn2jRbnBxAzV3zZPu+/zqY4zhD8hBqnorGcxH2 0Mmt9Kw74fZ4YoPFQ7++GSWJukO/YpIrSLyvH8rcNJ6x0M7rUqO8fPLNrffWVX7kNBEC WUrRTuuCHgHVcJGxxVnjRSc9TgNt6oAaSSCARHEPp+FNIaEo+c2eJ8Tgl55tvigDpvui BeHA== X-Gm-Message-State: APuU4Z97bJ87HzxREs1gfcFUz3UmERlzCNJtRhpj1aFrbQ/TLy4ePmRv A7GHy08qRBm4ka2H21IcyhDkrC6/EjtUMsyDtRepnOyyBU8vho2D2HypSSfzig== X-Gm-Gg: AYBFou1wp0MJbkTqC0ES0O513M0d3m8lMjn4MucUqQPxH6xh+Cu/gmTKP9ciA3LO1LD J/+1sp0iIVK6zPP8uFijcIC9vuZobk3h6LPtPXqd4oz6hvJUmsIHq2mjJOuEynyyfWRAoSjCfDH 36ik+DfJKcXuFlByYKqxZjvGlFY8yF5Vs4kpOAopkmttZqcobMoakIMSCgU6cnFfE88hqH5sXJS ce4DBaS1xoAJ+AYEE2vdhH/b0mldI6W9NK46yXFNr1gC/M590fQdI1uefK6Mf9p71KzPXwExaQW yLE6AMpw95y+39M8SMCB8WVAF8Xjr0Nbgh74LCziFjStgFB1X+906redkQqpX88QLX7oGSUGTsj RH9RebTSpT+qSqSC4C+vE1PGH+RnDb6ezGC26VnIODWrk6uGLStTnGwRlszN4K598eWnZTp+a/a SylfF0Wls8CR5olG/YkzOG0W8Eo1UDUg0zfOiDQpiCA1yaAYBLiRKIUKbJ9sLUb1tJSldB+abiz kV2U6lte7X6rS/ERgIOuLW53tu4y8TfiogO9BHDi+jLOrKiZLdajK1wOxTPWGa1yzfX1lu6qsl7 SzB8gz6rHqFVqf7jiDqHFk/CF0sOC9jewB8Xzql/zEo= X-Received: by 2002:a05:600c:b90:b0:4a7:76fa:87e9 with SMTP id 5b1f17b1804b1-4bb8892cb02mr79918945e9.21.1795193127926; Fri, 20 Nov 2026 08:45:27 -0800 (PST) Sender: "Ivan A. Melnikov" Date: Fri, 20 Nov 2026 20:45:25 +0400 From: "Ivan A. Melnikov" To: ALT Linux kernel packages development , Alexey Shabalin Message-ID: Mail-Followup-To: ALT Linux kernel packages development , Alexey Shabalin References: <20261118144935.3872281-1-shaba@altlinux.org> <20261118144935.3872281-12-shaba@altlinux.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fnngqj4ggtfmk5cc" Content-Disposition: inline In-Reply-To: <20261118144935.3872281-12-shaba@altlinux.org> Subject: Re: [d-kernel] [PATCH v2 6.12/sisyphus 11/29] crypto/krb5: Implement the AES enctypes from rfc3962 X-BeenThere: devel-kernel@lists.altlinux.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: ALT Linux kernel packages development List-Id: ALT Linux kernel packages development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Nov 2026 16:45:31 -0000 Archived-At: List-Archive: List-Post: --fnngqj4ggtfmk5cc Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [d-kernel] [PATCH v2 6.12/sisyphus 11/29] crypto/krb5: Implement the AES enctypes from rfc3962 MIME-Version: 1.0 On Wed, Nov 18, 2026 at 05:49:17PM +0300, Alexey Shabalin wrote: > From: David Howells >=20 > Implement the aes128-cts-hmac-sha1-96 and aes256-cts-hmac-sha1-96 enctypes > from rfc3962, using the rfc3961 kerberos 5 simplified crypto scheme. >=20 > Signed-off-by: David Howells > cc: Herbert Xu > cc: "David S. Miller" > cc: Chuck Lever > cc: Marc Dionne > cc: Eric Dumazet > cc: Jakub Kicinski > cc: Paolo Abeni > cc: Simon Horman > cc: linux-afs@lists.infradead.org > cc: linux-nfs@vger.kernel.org > cc: linux-crypto@vger.kernel.org > cc: netdev@vger.kernel.org > (cherry picked from commit 7c164b66b276c49b3888d3280e1b70a85732a38c) > Signed-off-by: Alexey Shabalin > --- > crypto/krb5/Kconfig | 1 + > crypto/krb5/Makefile | 3 +- > crypto/krb5/internal.h | 6 ++ > crypto/krb5/krb5_api.c | 2 + > crypto/krb5/rfc3962_aes.c | 115 ++++++++++++++++++++++++++++++++++++++ > 5 files changed, 126 insertions(+), 1 deletion(-) > create mode 100644 crypto/krb5/rfc3962_aes.c >=20 > diff --git a/crypto/krb5/Kconfig b/crypto/krb5/Kconfig > index 079873618abf..2ad874990dc8 100644 > --- a/crypto/krb5/Kconfig > +++ b/crypto/krb5/Kconfig > @@ -5,6 +5,7 @@ config CRYPTO_KRB5 > select CRYPTO_AUTHENC > select CRYPTO_SKCIPHER > select CRYPTO_HASH_INFO > + select CRYPTO_HMAC > select CRYPTO_SHA1 > select CRYPTO_CBC > select CRYPTO_CTS > diff --git a/crypto/krb5/Makefile b/crypto/krb5/Makefile > index 8dad8e3bf086..35f21411abf8 100644 > --- a/crypto/krb5/Makefile > +++ b/crypto/krb5/Makefile > @@ -6,6 +6,7 @@ > krb5-y +=3D \ > krb5_kdf.o \ > krb5_api.o \ > - rfc3961_simplified.o > + rfc3961_simplified.o \ > + rfc3962_aes.o > =20 > obj-$(CONFIG_CRYPTO_KRB5) +=3D krb5.o > diff --git a/crypto/krb5/internal.h b/crypto/krb5/internal.h > index 07a47ddf3ea9..43f904a69e32 100644 > --- a/crypto/krb5/internal.h > +++ b/crypto/krb5/internal.h > @@ -179,3 +179,9 @@ int rfc3961_verify_mic(const struct krb5_enctype *krb= 5, > const struct krb5_buffer *metadata, > struct scatterlist *sg, unsigned int nr_sg, > size_t *_offset, size_t *_len); > + > +/* > + * rfc3962_aes.c > + */ > +extern const struct krb5_enctype krb5_aes128_cts_hmac_sha1_96; > +extern const struct krb5_enctype krb5_aes256_cts_hmac_sha1_96; > diff --git a/crypto/krb5/krb5_api.c b/crypto/krb5/krb5_api.c > index 8fc3a1b9d4ad..ecc6655953d5 100644 > --- a/crypto/krb5/krb5_api.c > +++ b/crypto/krb5/krb5_api.c > @@ -17,6 +17,8 @@ MODULE_AUTHOR("Red Hat, Inc."); > MODULE_LICENSE("GPL"); > =20 > static const struct krb5_enctype *const krb5_supported_enctypes[] =3D { > + &krb5_aes128_cts_hmac_sha1_96, > + &krb5_aes256_cts_hmac_sha1_96, > }; > =20 > /** > diff --git a/crypto/krb5/rfc3962_aes.c b/crypto/krb5/rfc3962_aes.c > new file mode 100644 > index 000000000000..5cbf8f4638b9 > --- /dev/null > +++ b/crypto/krb5/rfc3962_aes.c > @@ -0,0 +1,115 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* rfc3962 Advanced Encryption Standard (AES) Encryption for Kerberos 5 > + * > + * Parts borrowed from net/sunrpc/auth_gss/. > + */ > +/* > + * COPYRIGHT (c) 2008 > + * The Regents of the University of Michigan > + * ALL RIGHTS RESERVED > + * > + * Permission is granted to use, copy, create derivative works > + * and redistribute this software and such derivative works > + * for any purpose, so long as the name of The University of > + * Michigan is not used in any advertising or publicity > + * pertaining to the use of distribution of this software > + * without specific, written prior authorization. If the > + * above copyright notice or any other identification of the > + * University of Michigan is included in any copy of any > + * portion of this software, then the disclaimer below must > + * also be included. > + * > + * THIS SOFTWARE IS PROVIDED AS IS, WITHOUT REPRESENTATION > + * FROM THE UNIVERSITY OF MICHIGAN AS TO ITS FITNESS FOR ANY > + * PURPOSE, AND WITHOUT WARRANTY BY THE UNIVERSITY OF > + * MICHIGAN OF ANY KIND, EITHER EXPRESS OR IMPLIED, INCLUDING > + * WITHOUT LIMITATION THE IMPLIED WARRANTIES OF > + * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. THE > + * REGENTS OF THE UNIVERSITY OF MICHIGAN SHALL NOT BE LIABLE > + * FOR ANY DAMAGES, INCLUDING SPECIAL, INDIRECT, INCIDENTAL, OR > + * CONSEQUENTIAL DAMAGES, WITH RESPECT TO ANY CLAIM ARISING > + * OUT OF OR IN CONNECTION WITH THE USE OF THE SOFTWARE, EVEN > + * IF IT HAS BEEN OR IS HEREAFTER ADVISED OF THE POSSIBILITY OF > + * SUCH DAMAGES. > + */ > + > +/* > + * Copyright (C) 1998 by the FundsXpress, INC. > + * > + * All rights reserved. > + * > + * Export of this software from the United States of America may require > + * a specific license from the United States Government. It is the > + * responsibility of any person or organization contemplating export to > + * obtain such a license before exporting. > + * > + * WITHIN THAT CONSTRAINT, permission to use, copy, modify, and > + * distribute this software and its documentation for any purpose and > + * without fee is hereby granted, provided that the above copyright > + * notice appear in all copies and that both that copyright notice and > + * this permission notice appear in supporting documentation, and that > + * the name of FundsXpress. not be used in advertising or publicity pert= aining > + * to distribution of the software without specific, written prior > + * permission. FundsXpress makes no representations about the suitabili= ty of > + * this software for any purpose. It is provided "as is" without express > + * or implied warranty. > + * > + * THIS SOFTWARE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR > + * IMPLIED WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED > + * WARRANTIES OF MERCHANTIBILITY AND FITNESS FOR A PARTICULAR PURPOSE. > + */ > + > +/* > + * Copyright (C) 2025 Red Hat, Inc. All Rights Reserved. > + * Written by David Howells (dhowells@redhat.com) > + */ > + > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > + > +#include "internal.h" > + > +const struct krb5_enctype krb5_aes128_cts_hmac_sha1_96 =3D { > + .etype =3D KRB5_ENCTYPE_AES128_CTS_HMAC_SHA1_96, > + .ctype =3D KRB5_CKSUMTYPE_HMAC_SHA1_96_AES128, > + .name =3D "aes128-cts-hmac-sha1-96", > + .encrypt_name =3D "krb5enc(hmac(sha1),cts(cbc(aes)))", Here krb5enc template is used, but it is not part of the series, nor is present in 6.12. This looks problematic to me, as these enctypes are exposed via crypto_krb5_find_enctype(...). Of course, ceph hardcodes KRB5_ENCTYPE_AES256_CTS_HMAC_SHA384_192 when calls crypto_krb5_find_enctype, so it's not problem for the intended usecase of the series; and there are no other in-tree callers of this function. But it's exported, and we should not present such half-backproted stuff to out-of-tree modules, or any other in-tree caller that might appear in the future. Please either backport upstream commit d1775a177f7f ("crypto: Add 'krb5enc' hash and cipher AEAD algorithm") with all its fixes, or drop the enctypes that use "krb5enc" enctype from the series. > + .cksum_name =3D "hmac(sha1)", > + .hash_name =3D "sha1", > + .derivation_enc =3D "cts(cbc(aes))", > + .key_bytes =3D 16, > + .key_len =3D 16, > + .Kc_len =3D 16, > + .Ke_len =3D 16, > + .Ki_len =3D 16, > + .block_len =3D 16, > + .conf_len =3D 16, > + .cksum_len =3D 12, > + .hash_len =3D 20, > + .prf_len =3D 16, > + .keyed_cksum =3D true, > + .random_to_key =3D NULL, /* Identity */ > + .profile =3D &rfc3961_simplified_profile, > +}; > + > +const struct krb5_enctype krb5_aes256_cts_hmac_sha1_96 =3D { > + .etype =3D KRB5_ENCTYPE_AES256_CTS_HMAC_SHA1_96, > + .ctype =3D KRB5_CKSUMTYPE_HMAC_SHA1_96_AES256, > + .name =3D "aes256-cts-hmac-sha1-96", > + .encrypt_name =3D "krb5enc(hmac(sha1),cts(cbc(aes)))", > + .cksum_name =3D "hmac(sha1)", > + .hash_name =3D "sha1", > + .derivation_enc =3D "cts(cbc(aes))", > + .key_bytes =3D 32, > + .key_len =3D 32, > + .Kc_len =3D 32, > + .Ke_len =3D 32, > + .Ki_len =3D 32, > + .block_len =3D 16, > + .conf_len =3D 16, > + .cksum_len =3D 12, > + .hash_len =3D 20, > + .prf_len =3D 16, > + .keyed_cksum =3D true, > + .random_to_key =3D NULL, /* Identity */ > + .profile =3D &rfc3961_simplified_profile, > +}; > --=20 > 2.50.1 >=20 > _______________________________________________ > devel-kernel mailing list > devel-kernel@lists.altlinux.org > https://lists.altlinux.org/mailman/listinfo/devel-kernel --=20 wbr, iv m. --fnngqj4ggtfmk5cc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJPBAABCAA5FiEEmAaVXvwlC48UPhs7IxaW1LxEwe4FAmsAeSUbFIAAAAAABAAO bWFudTIsMi41KzEuMTIsMiwyAAoJECMWltS8RMHuAPgP/3pMEZFmBwzcG3jSppxN Y2/fXFTjCISmV4sya+/6CK8p1F0PX9fh8da3kYhKcTtI5Ndk+Hr3TWNwrKRBtEb9 932MuAQ68fxiwDW0n8I0ZcNGNGjZR0CgJhxOnUg8ughg5JO2tC7r6gx9M2lca0FQ b1GNV8pW2CnijAqyoOtmV7TrkxbySRuQBIylJk7CzugYWIBl3Zh90Y0M/Ytr3Bem f5Zeli/uXDX2fIo3cqMCdZHhC9r3KsJe6A7Ng0/DhbQPfgOU0xDHgDA4he19lz05 do+sajXIPa5zQzkISH7GhI5kJNUkUmme+8F1NZzgfJWKfgwIRnhbC3oczJKP0bcu pekGYLWRCgENfkTII32u36EQqVR1nB1mW52Y4hSEEnt5OM2zTOPHY7m8noCW/Ybh 6EBrjOB/CFtheNGlvshBUXSem8arSg+59UHA5Ii3xL9eXpqKAkMCOxKYx14I+i0G W/An4q21/Zq6gTHlp9neetTeZgesC90FAMaGL+0nayQOr765e/s9tq3nCh1GXfQv hrD5uL0mHRFDxjXmaxw4PfIckOQd9ipvxBBxSqYPyfYJ9ndT04N0uB05uThCocc3 Z6nYKWYUDNPywJraVGcIAJ8n3NTcwpfhu5EBUTSsvEp0PTQ1QTOSDLC4oAONDZ+2 0yVsBEiFnVQXjlTfJkTIQSR1 =G1bG -----END PGP SIGNATURE----- --fnngqj4ggtfmk5cc--