Re: [d-kernel] [PATCH v5] AltHa: handle setcap binaries in the same way as setuid ones

["Vladimir D. Seleznev" <vseleznv@altlinux.org>]

On Tue, May 31, 2022 at 09:45:03AM +0300, Dmitry V. Levin wrote:
> On Tue, May 31, 2022 at 12:28:19AM +0300, Vladimir D. Seleznev wrote:
> > On Mon, May 30, 2022 at 06:45:09PM +0300, Dmitry V. Levin wrote:
> > > On Mon, May 30, 2022 at 06:24:12PM +0300, Vladimir D. Seleznev wrote:
> > > > On Mon, May 30, 2022 at 06:11:25PM +0300, Vitaly Chikunov wrote:
> > > [...]
> > > > > What about tests?
> > > > 
> > > > I'm not ready to put efforts for tests at this moment. Please apply the
> > > > patch, the tests can be a future work for this module.
> > > 
> > > In the absence of tests, how can we make sure the new feature works properly?
> > 
> > I tested it. The tests are good, but how do you know they are correct? I
> > don't mind to write tests but not now.
> 
> Tests are crucial in proving that new features work properly.
> In some projects, e.g. strace, a new feature is not merged
> until accompanied with a proper test.
> 
> What's stopping you from supplying a test now?

I'm not an expert in kernel tests framework, so I need to involve time
to learn it. vt@ suggested taking as an example kiosk test, but as far
as I understand it does not use kernel test facility, instead it is
written independently, and it poorly suitable for altha nosuid
functionality. Besides, the kiost test does not run during build process
(correct me if I'm wrong), so its presence does not make things any
better.

AltHa code is almost stand-alone and does not change any part of the
vanilla kernel. I think if it does not work as expected, users will
report that (and I use it).

-- 
   WBR,
   Vladimir D. Seleznev