From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <asheplyakov@basealt.ru>
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on
 sa.local.altlinux.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.3 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 RP_MATCHES_RCVD autolearn=unavailable autolearn_force=no version=3.4.1
Date: Fri, 14 Oct 2022 13:35:47 +0400
From: Alexey Sheplyakov <asheplyakov@basealt.ru>
To: ALT Linux kernel packages development <devel-kernel@lists.altlinux.org>
Message-ID: <Y0ktc89gHRASEKqr@asheplyakov-rocket>
References: <20221013143335.947243-1-asheplyakov@basealt.ru>
 <20221014020205.gnlayjl3xhsumwgg@altlinux.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20221014020205.gnlayjl3xhsumwgg@altlinux.org>
Cc: rst@basealt.ru, sin@basealt.ru, nir@basealt.ru, manton@basealt.ru
Subject: Re: [d-kernel] [PATCH] [p10/std-def] phy: realtek: leds
 configuration for RTL8211f
X-BeenThere: devel-kernel@lists.altlinux.org
X-Mailman-Version: 2.1.12
Precedence: list
Reply-To: ALT Linux kernel packages development
 <devel-kernel@lists.altlinux.org>
List-Id: ALT Linux kernel packages development
 <devel-kernel.lists.altlinux.org>
List-Unsubscribe: <https://lists.altlinux.org/mailman/options/devel-kernel>,
 <mailto:devel-kernel-request@lists.altlinux.org?subject=unsubscribe>
List-Archive: <http://lists.altlinux.org/pipermail/devel-kernel>
List-Post: <mailto:devel-kernel@lists.altlinux.org>
List-Help: <mailto:devel-kernel-request@lists.altlinux.org?subject=help>
List-Subscribe: <https://lists.altlinux.org/mailman/listinfo/devel-kernel>,
 <mailto:devel-kernel-request@lists.altlinux.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Oct 2022 09:36:00 -0000
Archived-At: <http://lore.altlinux.org/devel-kernel/Y0ktc89gHRASEKqr@asheplyakov-rocket/>
List-Archive: <http://lore.altlinux.org/devel-kernel/>
List-Post: <mailto:devel-kernel@altlinux.org>

Здравствуйте!

On Fri, Oct 14, 2022 at 05:02:05AM +0300, Vitaly Chikunov wrote:
> Обратил внимание на "Если мы хотим этот патч в std-def/un-def -
> требуется тщательное тестирование на регрессии на x86_64 системах."

Замечание касается изначальной версии патча: https://my.basealt.space/attachments/140630

Патч, который я прислал, ничего не меняет на x86{,_64}:

> Configure leds according to 'realtek,led-mode', 'realtek,led[0-2]-control'
> knobs (specified in DTB). Note that *all* of these parameters must be
> set in DTB for this to work.

На x86{,_64} нет device tree, параметрам неоткуда взяться, и никаких
изменений нет:

> +static void rtl8211f_config_led(struct phy_device *phydev)
> +{
> +	struct device *dev = &phydev->mdio.dev;
> +	struct device_node *of_node = dev->of_node;
> +	u16 val;
> +	u32 led_mode, led0_ctrl, led1_ctrl, led2_ctrl;
> +	int ret;
> +
> +	ret = of_property_read_u32(of_node, "realtek,led-mode", &led_mode);
> +	if (ret < 0) {
> +		dev_dbg(dev, "refusing to reconfigure leds: no 'realtek,led-mode' in dtb\n");
> +		return;
> +	}

dev->of_node == NULL, поэтому of_property_read_u32 вернёт ошибку, и
rtl8211f_config_led ничего не делает с устройством.

Более того, даже на системе с device tree нужно, чтобы в описании phy
присутствовали все 4 параметра "realtek,led-mode", "realtek,led0-control",
"realtek,led1-control", "realtek,led2-control".

Всего доброго,
	Алексей