From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vt@altlinux.org>
Date: Mon, 9 May 2022 14:47:07 +0300
From: Vitaly Chikunov <vt@altlinux.org>
To: ALT Linux kernel packages development <devel-kernel@lists.altlinux.org>
Message-ID: <20220509114707.fzkjag52ty6utlk6@altlinux.org>
References: <20220428145541.909063-1-vseleznv@altlinux.org>
 <20220428145955.909376-1-vseleznv@altlinux.org>
 <20220428145955.909376-2-vseleznv@altlinux.org>
 <20220505155505.4gsegk4o5pba3f6j@altlinux.org>
 <YnRhoA7OTxoIrGb8@portlab>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <YnRhoA7OTxoIrGb8@portlab>
Subject: Re: [d-kernel] [PATCH] AltHa: nosuid handles capabilities as well
X-BeenThere: devel-kernel@lists.altlinux.org
X-Mailman-Version: 2.1.12
Precedence: list
Reply-To: ALT Linux kernel packages development
 <devel-kernel@lists.altlinux.org>
List-Id: ALT Linux kernel packages development
 <devel-kernel.lists.altlinux.org>
List-Unsubscribe: <https://lists.altlinux.org/mailman/options/devel-kernel>,
 <mailto:devel-kernel-request@lists.altlinux.org?subject=unsubscribe>
List-Archive: <http://lists.altlinux.org/pipermail/devel-kernel>
List-Post: <mailto:devel-kernel@lists.altlinux.org>
List-Help: <mailto:devel-kernel-request@lists.altlinux.org?subject=help>
List-Subscribe: <https://lists.altlinux.org/mailman/listinfo/devel-kernel>,
 <mailto:devel-kernel-request@lists.altlinux.org?subject=subscribe>
X-List-Received-Date: Mon, 09 May 2022 11:47:07 -0000
Archived-At: <http://lore.altlinux.org/devel-kernel/20220509114707.fzkjag52ty6utlk6@altlinux.org/>
List-Archive: <http://lore.altlinux.org/devel-kernel/>
List-Post: <mailto:devel-kernel@altlinux.org>

Vladimir,

On Fri, May 06, 2022 at 02:45:36AM +0300, Vladimir D. Seleznev wrote:
> On Thu, May 05, 2022 at 06:55:05PM +0300, Vitaly Chikunov wrote:
> 
> > On Thu, Apr 28, 2022 at 02:59:55PM +0000, Vladimir D. Seleznev wrote:
> > [skip]
> > 
> >   CC      security/altha/altha_lsm.o
> > security/altha/altha_lsm.c: In function 'altha_bprm_creds_from_file':
> > security/altha/altha_lsm.c:284:32: error: unused variable 'cur_euid' [-Werror=unused-variable]
> >   284 |                 uid_t cur_uid, cur_euid;
> >       |                                ^~~~~~~~
> > cc1: all warnings being treated as errors
> > make[2]: *** [scripts/Makefile.build:277: security/altha/altha_lsm.o] Error 1
> > make[1]: *** [scripts/Makefile.build:540: security/altha] Error 2
> > make: *** [Makefile:1868: security] Error 2
> > make: *** Waiting for unfinished jobs....
> 
> Hmm, interesting. My build is OK. I'll see on this tomorrow.

While you will look at it tomorrow, please also add minimal tests, for
positive and negative case, also preferable make them self-contained
enough to be runnable in vm-run. Example of the test in
  security/kiosk/kiosk-test.sh

Thanks,

> 
> -- 
>    WBR,
>    Vladimir D. Seleznev
> _______________________________________________
> devel-kernel mailing list
> devel-kernel@lists.altlinux.org
> https://lists.altlinux.org/mailman/listinfo/devel-kernel