ALT Linux kernel packages development
 help / color / mirror / Atom feed
From: Vitaly Chikunov <vt@altlinux.org>
To: ALT Linux kernel packages development <devel-kernel@lists.altlinux.org>
Subject: Re: [d-kernel] [PATCH] AltHa: nosuid handles capabilities as well
Date: Mon, 9 May 2022 14:47:07 +0300
Message-ID: <20220509114707.fzkjag52ty6utlk6@altlinux.org> (raw)
In-Reply-To: <YnRhoA7OTxoIrGb8@portlab>

Vladimir,

On Fri, May 06, 2022 at 02:45:36AM +0300, Vladimir D. Seleznev wrote:
> On Thu, May 05, 2022 at 06:55:05PM +0300, Vitaly Chikunov wrote:
> 
> > On Thu, Apr 28, 2022 at 02:59:55PM +0000, Vladimir D. Seleznev wrote:
> > [skip]
> > 
> >   CC      security/altha/altha_lsm.o
> > security/altha/altha_lsm.c: In function 'altha_bprm_creds_from_file':
> > security/altha/altha_lsm.c:284:32: error: unused variable 'cur_euid' [-Werror=unused-variable]
> >   284 |                 uid_t cur_uid, cur_euid;
> >       |                                ^~~~~~~~
> > cc1: all warnings being treated as errors
> > make[2]: *** [scripts/Makefile.build:277: security/altha/altha_lsm.o] Error 1
> > make[1]: *** [scripts/Makefile.build:540: security/altha] Error 2
> > make: *** [Makefile:1868: security] Error 2
> > make: *** Waiting for unfinished jobs....
> 
> Hmm, interesting. My build is OK. I'll see on this tomorrow.

While you will look at it tomorrow, please also add minimal tests, for
positive and negative case, also preferable make them self-contained
enough to be runnable in vm-run. Example of the test in
  security/kiosk/kiosk-test.sh

Thanks,

> 
> -- 
>    WBR,
>    Vladimir D. Seleznev
> _______________________________________________
> devel-kernel mailing list
> devel-kernel@lists.altlinux.org
> https://lists.altlinux.org/mailman/listinfo/devel-kernel


  reply	other threads:[~2022-05-09 11:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-26  9:47 [d-kernel] (без темы) Vladimir D. Seleznev
2022-04-26  9:47 ` [d-kernel] [PATCH] AltHa: nosuid handles capabilities as well Vladimir D. Seleznev
2022-04-26 21:09   ` Vitaly Chikunov
2022-04-28  9:42     ` Vladimir D. Seleznev
2022-04-28 22:18       ` Vitaly Chikunov
2022-04-28 23:24         ` Vladimir D. Seleznev
2022-04-29  0:04           ` Vitaly Chikunov
2022-04-26 19:23 ` [d-kernel] (без темы) " Vitaly Chikunov
2022-04-28 14:55 ` [d-kernel] [PATCH] " Vladimir D. Seleznev
2022-04-28 14:59   ` [d-kernel] AltHa Covers capabilities Vladimir D. Seleznev
2022-04-28 14:59     ` [d-kernel] [PATCH] AltHa: nosuid handles capabilities as well Vladimir D. Seleznev
2022-05-05 15:55       ` Vitaly Chikunov
2022-05-05 23:45         ` Vladimir D. Seleznev
2022-05-09 11:47           ` Vitaly Chikunov [this message]
2022-05-10 21:36             ` Vladimir D. Seleznev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220509114707.fzkjag52ty6utlk6@altlinux.org \
    --to=vt@altlinux.org \
    --cc=devel-kernel@lists.altlinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

ALT Linux kernel packages development

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://lore.altlinux.org/devel-kernel/0 devel-kernel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 devel-kernel devel-kernel/ http://lore.altlinux.org/devel-kernel \
		devel-kernel@altlinux.org devel-kernel@altlinux.ru devel-kernel@altlinux.com
	public-inbox-index devel-kernel

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://lore.altlinux.org/org.altlinux.lists.devel-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git