Re: [d-kernel] [PATCH 2/3] Revert "Input: clear BTN_RIGHT/MIDDLE on buttonpads"

[Vitaly Chikunov <vt@altlinux.org>]

On Thu, Mar 24, 2022 at 10:51:24AM +0300, nickel@altlinux.org wrote:
> From: Nikolai Kostrigin <nickel@altlinux.org>
> 
> This commit breaks touchpad right button operation on ICL Si1516 laptop

Как я понимаю, вы сделали выбор в пользу ICL Si1516 laptop, но против:

     - Chuwi AeroBook Plus
     - Chuwi Gemibook
     - Framework Laptop
     - GPD Win Max
     - Huawei MateBook 2020
     - Prestigio Smartbook 141 C2
     - Purism Librem 14v1
     - StarLite Mk II   - AMI firmware
     - StarLite Mk II   - Coreboot firmware
     - StarLite Mk III  - AMI firmware
     - StarLite Mk III  - Coreboot firmware
     - StarLabTop Mk IV - AMI firmware
     - StarLabTop Mk IV - Coreboot firmware
     - StarBook Mk V

Почему почему этот laptop должен наладиться, а эти сломаться?

> 
> Refer to ALT#42123
> 
> This reverts commit 6279c5263dedc6af67c194ec8e0f91bc2849cdf8.
> 
> Reported-by: Sergey Ivanov <zagagyka@basealt.ru>
> Signed-off-by: Nikolai Kostrigin <nickel@altlinux.org>
> ---
>  drivers/input/input.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/input/input.c b/drivers/input/input.c
> index c3139bc2aa0d..ccaeb2426385 100644
> --- a/drivers/input/input.c
> +++ b/drivers/input/input.c
> @@ -2285,12 +2285,6 @@ int input_register_device(struct input_dev *dev)
>  	/* KEY_RESERVED is not supposed to be transmitted to userspace. */
>  	__clear_bit(KEY_RESERVED, dev->keybit);
>  
> -	/* Buttonpads should not map BTN_RIGHT and/or BTN_MIDDLE. */
> -	if (test_bit(INPUT_PROP_BUTTONPAD, dev->propbit)) {
> -		__clear_bit(BTN_RIGHT, dev->keybit);
> -		__clear_bit(BTN_MIDDLE, dev->keybit);
> -	}
> -
>  	/* Make sure that bitmasks not mentioned in dev->evbit are clean. */
>  	input_cleanse_bitmasks(dev);
>  
> -- 
> 2.33.0
> 
> _______________________________________________
> devel-kernel mailing list
> devel-kernel@lists.altlinux.org
> https://lists.altlinux.org/mailman/listinfo/devel-kernel