From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <midyukov-anton@ya.ru>
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on
 sa.local.altlinux.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
 DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM autolearn=ham autolearn_force=no
 version=3.4.1
X-Yandex-Fwd: 1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ya.ru; s=mail;
 t=1691203715; bh=vA17roJUVH8ar14evZbKqgggvnXxu9yioa1D+PCkEls=;
 h=In-Reply-To:From:Date:References:To:Subject:Message-ID;
 b=ToyJQZkBxhPV2K1TXZKFnaKwLbmf+q/zJzmqqgeHcg6f5eQvdqYzaFCdAT1E/b5dX
 ldr1R5kFhhZAgOECKrG0lZb4eI71iu4vEO9eYBcehh2O2YEN4nSkHFiCm7ScifQmZ4
 G9xsw0g+D2NCedx6iOmlzY9Qyh8FG1yMXBgKhnjU=
Authentication-Results: mail-nwsmtp-smtp-production-canary-88.sas.yp-c.yandex.net;
 dkim=pass header.i=@ya.ru
Message-ID: <a148a9da-8742-6c15-95e8-a28b96011c0a@ya.ru>
Date: Sat, 5 Aug 2023 09:48:33 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Content-Language: ru
To: devel-distro@lists.altlinux.org
References: <20230804204257.3619236-1-glebfm@altlinux.org>
From: =?UTF-8?B?0JDQvdGC0L7QvSDQnNC40LTRjtC60L7Qsg==?= <midyukov-anton@ya.ru>
In-Reply-To: <20230804204257.3619236-1-glebfm@altlinux.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [devel-distro] [PATCH] lib/boot.mk: do not define BOOTLOADER
 type for e2k
X-BeenThere: devel-distro@lists.altlinux.org
X-Mailman-Version: 2.1.12
Precedence: list
Reply-To: Distributions development <devel-distro@lists.altlinux.org>
List-Id: Distributions development <devel-distro.lists.altlinux.org>
List-Unsubscribe: <https://lists.altlinux.org/mailman/options/devel-distro>,
 <mailto:devel-distro-request@lists.altlinux.org?subject=unsubscribe>
List-Archive: <http://lists.altlinux.org/pipermail/devel-distro>
List-Post: <mailto:devel-distro@lists.altlinux.org>
List-Help: <mailto:devel-distro-request@lists.altlinux.org?subject=help>
List-Subscribe: <https://lists.altlinux.org/mailman/listinfo/devel-distro>,
 <mailto:devel-distro-request@lists.altlinux.org?subject=subscribe>
X-List-Received-Date: Sat, 05 Aug 2023 02:48:38 -0000
Archived-At: <http://lore.altlinux.org/devel-distro/a148a9da-8742-6c15-95e8-a28b96011c0a@ya.ru/>
List-Archive: <http://lore.altlinux.org/devel-distro/>

05.08.2023 03:42, Gleb Fotengauer-Malinovskiy пишет:
> It is unnecessary to define the BOOTLOADER type for e2k in this context.
> The reason is that images for e2k use the mkimage isodata pack method,
> which is unaffected by any value of the BOOTLOADER variable (BOOT_TYPE
> in the mkimage).  Therefore, defining the BOOTLOADER type does not make
> any sense.
> 

Этот коммит ломает сборку на e2k, так как в sub.in/stage1/Makefile:
ifeq (,$(BOOTLOADER))
$(error BOOTLOADER not defined)
endif

Но скорее всего эта проверка стала излишней после упразднения в этом Makefile
copy-$(BOOTLOADER)

> Fixes: e8fcdaf8 ("lib/boot.mk: Set IMAGE_PACKTYPE to isodata for e2k")
> ---
>  lib/boot.mk | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/lib/boot.mk b/lib/boot.mk
> index 2c58f378..e8940dc7 100644
> --- a/lib/boot.mk
> +++ b/lib/boot.mk
> @@ -13,7 +13,6 @@ ifeq (,$(filter-out aarch64 riscv64 loongarch64,$(ARCH)))
>  	@$(call try,BOOTLOADER,efiboot)
>  endif
>  ifeq (,$(filter-out e2k%,$(ARCH)))
> -	@$(call try,BOOTLOADER,e2kboot)
>  	@$(call set,IMAGE_PACKTYPE,isodata)
>  endif
>  ifeq (,$(filter-out ppc64le,$(ARCH)))

-- 
С уважением, Антон Мидюков <antohami@altlinux.org>