From: Michael Shigorin <mike@osdn.org.ua>
To: Community@lists.altlinux.org
Subject: Re: [Comm] shell logical expressions
Date: Fri, 17 Aug 2007 14:05:22 +0300
Message-ID: <20070817110522.GH1903@osdn.org.ua> (raw)
In-Reply-To: <46C57871.7000007@stc.donpac.ru>
On Fri, Aug 17, 2007 at 02:29:05PM +0400, Eugene Prokopiev wrote:
> Нужно выполнить несколько команд, если хотя бы одна вернула не
> 0, тоже вернуть не 0 и выругаться. Делаю примерно так:
>
> #!/bin/sh
> [ `drbdadm state all | awk -F'/' '{print $1}'` == "Primary" ]
> partition=$?
> grep drbd0 /proc/mounts > /dev/null
> filesystem=$?
Я бы переписал где-то так:
[ `drbdadm state all | awk -F'/' '{print $1}'` == "Primary" ] \
&& grep drbd0 /proc/mounts > /dev/null \
&& exit 0
mail .....
Почитай скрипты из пакетов (с)авторства ldv@ и legion@ (в т.ч.
control, alterator-*) -- там много интересного можно подметить
;-)
У Лёши за последний год или два стиль очень интересный и сжатый
стал. При этом читается и работает.
> if [ $partition != '0' ] || [ $filesystem != '0' ] ; then
> mail -s "HAD Monitor fail" root << EOF
> drbd state:
> `cat /proc/drbd`
>
> mount state:
> `grep drbd0 /proc/mounts`
> EOF
> exit 1
> else
> exit 0
> fi
>
> Но не оставляет ощущение кривизны куска кода с if. Можно правильнее/проще?
>
--
---- WBR, Michael Shigorin <mike@altlinux.ru>
------ Linux.Kiev http://www.linux.kiev.ua/
next prev parent reply other threads:[~2007-08-17 11:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-17 10:29 Eugene Prokopiev
2007-08-17 11:05 ` Michael Shigorin [this message]
2007-08-20 6:17 ` Eugene Prokopiev
2007-08-20 8:37 ` Michael Shigorin
2007-08-20 6:18 ` Eugene Prokopiev
2007-08-17 11:10 ` Denis Kirienko
2007-08-20 6:25 ` Eugene Prokopiev
2007-08-20 7:48 ` Denis Kirienko
2007-08-20 9:35 ` Eugene Prokopiev
2007-08-20 9:45 ` Michael Shigorin
2007-08-20 10:01 ` Andrew Borodin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070817110522.GH1903@osdn.org.ua \
--to=mike@osdn.org.ua \
--cc=Community@lists.altlinux.org \
--cc=shigorin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
ALT Linux Community general discussions
This inbox may be cloned and mirrored by anyone:
git clone --mirror http://lore.altlinux.org/community/0 community/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 community community/ http://lore.altlinux.org/community \
mandrake-russian@linuxteam.iplabs.ru community@lists.altlinux.org community@lists.altlinux.ru community@lists.altlinux.com
public-inbox-index community
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://lore.altlinux.org/org.altlinux.lists.community
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git