Linux console tools development discussion
 help / color / mirror / Atom feed
From: Michael Schutte <michi@uiae.at>
To: kbd@lists.altlinux.org
Subject: [kbd] [PATCH] Never handle plain ASCII characters as Unicode
Date: Fri, 24 Jul 2009 13:55:20 +0200
Message-ID: <1248436520-21443-1-git-send-email-michi@uiae.at> (raw)

This doesn’t seem to work for compose: The Unicode keysym representing
an ASCII char gets inserted and the kernel waits for another keypress to
be “dead”.

Signed-off-by: Michael Schutte <michi@uiae.at>
---
 src/ksyms.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/ksyms.c b/src/ksyms.c
index 4055e54..f68ea30 100644
--- a/src/ksyms.c
+++ b/src/ksyms.c
@@ -1858,16 +1858,16 @@ convert_code(int code, int direction)
 
 	if (KTYP(code) == KT_META)
 		return code;
+	else if (!input_is_unicode && code < 0x80)
+		/* basic ASCII is fine in every situation */
+		return code;
+	else if (input_is_unicode && (code ^ 0xf000) < 0x80)
+		/* so is Unicode "Basic Latin" */
+		return code ^ 0xf000;
 	else if ((input_is_unicode && direction == TO_UNICODE) ||
 		 (!input_is_unicode && direction == TO_8BIT))
 		/* no conversion necessary */
 		result = code;
-	else if (!input_is_unicode && code < 0x80)
-		/* convert ASCII chars without looking them up */
-		result = (direction == TO_UNICODE) ? (code ^ 0xf000) : code;
-	else if (input_is_unicode && (code ^ 0xf000) < 0x80)
-		/* same for Unicode "Basic Latin" */
-		result = (direction == TO_UNICODE) ? code : (code ^ 0xf000);
 	else {
 		/* depending on direction, this will give us either an 8-bit
 		 * K(KTYP, KVAL) or a Unicode keysym xor 0xf000 */
-- 
1.5.6.5



             reply	other threads:[~2009-07-24 11:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-24 11:55 Michael Schutte [this message]
2009-07-28 22:10 ` Alexey Gladkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1248436520-21443-1-git-send-email-michi@uiae.at \
    --to=michi@uiae.at \
    --cc=kbd@lists.altlinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux console tools development discussion

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://lore.altlinux.org/kbd/0 kbd/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 kbd kbd/ http://lore.altlinux.org/kbd \
		kbd@lists.altlinux.org kbd@lists.altlinux.ru kbd@lists.altlinux.com
	public-inbox-index kbd

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://lore.altlinux.org/org.altlinux.lists.kbd


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git