From: Michael Schutte <m.schutte.jr@gmail.com> To: kbd@lists.altlinux.org Subject: [kbd] [PATCH] src/openvt.c: Close fd0 in parent after child has returned Date: Mon, 24 Mar 2008 16:35:30 +0100 Message-ID: <1206372930-6971-1-git-send-email-m.schutte.jr@gmail.com> (raw) The race condition fix (commit 9d987…) introduces a regression which causes the parent to leave open the file descriptor pointing to the VT opened. This causes VT_DISALLOCATE to fail with an EBUSY error. Fixed by closing fd0 in the do_wait stanza. Signed-off-by: Michael Schutte <m.schutte.jr@gmail.com> --- src/openvt.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/openvt.c b/src/openvt.c index ffd0570..5e4443b 100644 --- a/src/openvt.c +++ b/src/openvt.c @@ -304,6 +304,8 @@ got_vtno: if ( do_wait ) { wait(&status); + if (!direct_exec) + close(fd0); if (show) { /* Switch back... */ if (ioctl(consfd, VT_ACTIVATE, vtstat.v_active)) { perror("VT_ACTIVATE"); -- 1.5.4.4
next reply other threads:[~2008-03-24 15:35 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-03-24 15:35 Michael Schutte [this message] 2008-03-24 16:02 ` Alexey Gladkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1206372930-6971-1-git-send-email-m.schutte.jr@gmail.com \ --to=m.schutte.jr@gmail.com \ --cc=kbd@lists.altlinux.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux console tools development discussion This inbox may be cloned and mirrored by anyone: git clone --mirror http://lore.altlinux.org/kbd/0 kbd/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 kbd kbd/ http://lore.altlinux.org/kbd \ kbd@lists.altlinux.org kbd@lists.altlinux.ru kbd@lists.altlinux.com public-inbox-index kbd Example config snippet for mirrors. Newsgroup available over NNTP: nntp://lore.altlinux.org/org.altlinux.lists.kbd AGPL code for this site: git clone https://public-inbox.org/public-inbox.git