Re: [devel] [PATCH for rpm] Add triggers circumvension for packagekit offline update

[Aleksei Nikiforov <darktemplar@altlinux.org>]

31.10.2019 15:59, Dmitry V. Levin пишет:
> On Thu, Oct 31, 2019 at 02:58:08PM +0300, Aleksei Nikiforov wrote:
>> Joint change with Oleg Solovyov (mcpain@)
> 
> Thanks.
> 
> It's not clear from the commit message why one might need to disable
> rpmdb --rebuilddb after rpm update.
> 
> Could you elaborate, please?
> 

packagekit offline update is implemented in following way:
1) system is preparing for offline update: all new installed packages 
are downloaded, etc.
2) system is rebooting into special systemd offline update mode upon 
user request.
3) in this offline update mode packagekit offline update service is 
performing system update using packagekit service activated via dbus.
4) Last step of systemd offline update is a reboot request. It must be 
made by offline update service. And packagekit offline update service 
does request it.

Thus, rpmdb --rebuilddb from rpm scripts would be in race against reboot 
request. Testing showed that it doesn't work properly in such 
conditions. In best case, rpmdb --rebuilddb doesn't do anything at all 
before reboot happens. Instead of hoping to get it work properly in such 
conditions, disabling it in rpm scripts and calling it right after 
update but before reboot request from packagekit offline update works fine:

http://git.altlinux.org/people/darktemplar/packages/?p=PackageKit.git;a=commitdiff;h=9b34f9657927dc748ec0a7b42cf2f58389a7f60a

A bit info about offline updates:
https://www.freedesktop.org/software/systemd/man/systemd.offline-updates.html

>> ---
>>   alt/rpm.spec | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/alt/rpm.spec b/alt/rpm.spec
>> index 6217493b7..d93e701b1 100644
>> --- a/alt/rpm.spec
>> +++ b/alt/rpm.spec
>> @@ -385,6 +385,7 @@ ls -A tests/rpmtests.dir 2>/dev/null ||:
>>   #[ ! -L %%_rpmlibdir/noarch-alt-%%_target_os ] || rm -f %%_rpmlibdir/noarch-alt-%%_target_os ||:
>>   
>>   %post
>> +if [ ! -f %_localstatedir/PackageKit/disable-rpm-triggers ]; then
>>   #chgrp %%name %%_localstatedir/%%name/[A-Z]*
>>   [ -n "$DURING_INSTALL" -o -n "$BTE_INSTALL" ] ||
>>           %_rpmlibdir/pdeath_execute $PPID %_rpmlibdir/postupdate
>> @@ -393,6 +394,7 @@ ls -A tests/rpmtests.dir 2>/dev/null ||:
>>   if set /var/cache/apt/*.bin && [ -f "$1" ]; then
>>           %_rpmlibdir/pdeath_execute $PPID rm -f "$@"
>>   fi
>> +fi
>>   :
> 
> If this change is needed, it should rather look this way:
> 
> if [ -f %_localstatedir/PackageKit/disable-rpm-triggers ]; then
> 	exit 0
> fi
> 
> 
> 
> _______________________________________________
> Devel mailing list
> Devel@lists.altlinux.org
> https://lists.altlinux.org/mailman/listinfo/devel
>