From: "Slava Semushin" <slava.semushin@gmail.com>
To: "ALT Devel discussion list" <devel@lists.altlinux.org>
Subject: Re: [devel] [git update] packages/rpmdb-utils: heads/master
Date: Thu, 5 Jul 2007 17:04:03 +0700
Message-ID: <75e139a00707050304y506d76f8xfd776629db3f6b83@mail.gmail.com> (raw)
In-Reply-To: <20070703134525.660A31A3402E@ssh.git.local.altlinux.org>
2007/7/3, Alexey Gladkov <legion / altlinux.org>:
[...]
> diff --git a/rpmdb-utils/rpmdb2binlist.c b/rpmdb-utils/rpmdb2binlist.c
> index 3a0b861..54726d2 100644
> --- a/rpmdb-utils/rpmdb2binlist.c
> +++ b/rpmdb-utils/rpmdb2binlist.c
> @@ -18,12 +18,15 @@
> ***** END LICENSE BLOCK ******/
>
> #include <stdio.h>
> +#include <string.h>
> #include <sys/types.h>
> #include <sys/stat.h>
> #include <fcntl.h>
> +#include <assert.h>
[...]
А зачем был добавлен хедер string.h? В добавленных в этом коммите
строках ни одна ф-ция из string.h не используется. Я посмотрел весь
файл и не нашел использования ф-ций из этого хедера.
На 99% уверен, что этот хедер здесь не нужен. А вот stdlib.h напротив
отсутствует, но нужен для ф-ции exit() и констант
EXIT_{SUCCESS,FAILURE}
--
+ Slava Semushin | slava.semushin @ gmail.com
+ ALT Linux Team | php-coder @ altlinux.ru
next parent reply other threads:[~2007-07-05 10:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-05 10:04 ` Slava Semushin [this message]
2007-07-05 13:47 ` Alexey Gladkov
2007-07-06 4:50 ` Slava Semushin
2007-07-06 6:49 ` Stanislav Ievlev
2007-07-06 12:51 ` Igor Zubkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75e139a00707050304y506d76f8xfd776629db3f6b83@mail.gmail.com \
--to=slava.semushin@gmail.com \
--cc=devel@lists.altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
ALT Linux Team development discussions
This inbox may be cloned and mirrored by anyone:
git clone --mirror http://lore.altlinux.org/devel/0 devel/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 devel devel/ http://lore.altlinux.org/devel \
devel@altlinux.org devel@altlinux.ru devel@lists.altlinux.org devel@lists.altlinux.ru devel@linux.iplabs.ru mandrake-russian@linuxteam.iplabs.ru sisyphus@linuxteam.iplabs.ru
public-inbox-index devel
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://lore.altlinux.org/org.altlinux.lists.devel
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git