From: Vitaly Kuznetsov <vitty@altlinux.ru>
To: ALT Devel discussion list <devel@lists.altlinux.org>
Subject: Re: [devel] [git update] packages/perl-mozldap: heads/master
Date: Mon, 09 Jul 2007 10:28:47 +0400
Message-ID: <4691D59F.4000906@altlinux.ru> (raw)
In-Reply-To: <75e139a00707082320u5e94af02t65a7983accdcfa68@mail.gmail.com>
Slava Semushin пишет:
> 2007/7/9, Vitaly Kuznetsov <vitty / altlinux.org>:
> [...]
>> +rm -f `find %buildroot -type f -name perllocal.pod -o -name .packlist`
>> +find %buildroot -name API.bs -a -size 0 -exec rm -f {} \;
>
> Как-то нелогично. Почему бы и в первом случае не использовать find +
> exec? Или даже в обоиз случаях find -delete
>
> [...]
>> # find and run the correct version of brp-compress
>> -if [ -x /usr/lib/rpm/brp-compress ] ; then
>> - /usr/lib/rpm/brp-compress
>> +if [ -x %_libdir/rpm/brp-compress ] ; then
>> + %_libdir/rpm/brp-compress
>> elif [ -x %_libdir/rpm/brp-compress ] ; then
>> %_libdir/rpm/brp-compress
>> fi
>
> Во-первых, вы тут перестарались с заменой макросов. После вашего
> изменения оба условия стали одинаковыми.
>
> Во-вторых, этот скрипт в АЛЬТе (если не ошибаюсь) запускается
> автоматически сам и этот код абсолютно не нужен.
>
> [...]
>> * Tue Oct 17 2006 Rich Megginson <richm@stanfordalumni.org> - 1.5-6
>> -- look for brp-compress first in /usr/lib then _libdir
>> +- look for brp-compress first in %_libdir then _libdir
> [...]
>
> Я бы не стал править записи в %changelog'е, которые делал не я сам
> (максимум удалить пробелы на концах строк, но не более).
>
>
Это я предложеный rpmcs тестирую ;)
не думал что он будет в changelog-е что-то менять
next prev parent reply other threads:[~2007-07-09 6:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-09 6:20 ` Slava Semushin
2007-07-09 6:28 ` Vitaly Kuznetsov [this message]
2007-07-09 6:31 ` Slava Semushin
2007-07-09 7:02 ` Денис Смирнов
2007-07-09 8:40 ` [devel] rm `find` (was: [git update] packages/perl-mozldap: heads/master) Michael Shigorin
2007-07-09 9:45 ` [devel] [git update] packages/perl-mozldap: heads/master Dmitry V. Levin
2007-07-09 10:01 ` Slava Semushin
2007-07-09 16:15 ` Anton Farygin
2007-07-09 21:42 ` Dmitry V. Levin
2007-07-10 4:57 ` Anton Farygin
2007-07-10 5:01 ` Slava Semushin
2007-07-09 11:51 ` [devel] [wiki] devel/TypicalPackagingErrors/FindRm Michael Shigorin
2007-07-09 16:13 ` [devel] [git update] packages/perl-mozldap: heads/master Anton Farygin
2007-07-09 22:01 ` [devel] find Security Considerations Dmitry V. Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4691D59F.4000906@altlinux.ru \
--to=vitty@altlinux.ru \
--cc=devel@lists.altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
ALT Linux Team development discussions
This inbox may be cloned and mirrored by anyone:
git clone --mirror http://lore.altlinux.org/devel/0 devel/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 devel devel/ http://lore.altlinux.org/devel \
devel@altlinux.org devel@altlinux.ru devel@lists.altlinux.org devel@lists.altlinux.ru devel@linux.iplabs.ru mandrake-russian@linuxteam.iplabs.ru sisyphus@linuxteam.iplabs.ru
public-inbox-index devel
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://lore.altlinux.org/org.altlinux.lists.devel
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git