From: Vladimir Lettiev <crux@gorodmasterov.com>
To: ALT Devel discussion list <devel@altlinux.ru>
Subject: Re: [devel] Re: I: Sisyphus-20050929 unmets: +2 (93/40)
Date: Sun, 02 Oct 2005 14:19:07 +0400
Message-ID: <433FB41B.7020804@gorodmasterov.com> (raw)
In-Reply-To: <20051001160154.GB20413@basalt.office.altlinux.org>
[-- Attachment #1: Type: text/plain, Size: 693 bytes --]
Dmitry V. Levin пишет:
>>На ядрах с Owl действительно наблюдаются проблемы при запуске тестов
>>этого пакета, кажется вот на такой конструкции:
>>
>>my $share = new IPC::ShareLite( .... some things here ....);
>>...
>>$share->store( 0 );
>>
>>Дальше тест не выполняется, висит, до нажатия Ctrl+C.
>>На 2.6.x естественно все ок.
>
> Это дело времени. :)
Я сделал патч для IPC::ShareLite.
Как мне показалось проблема в том, что данный модуль сначала делает
shmdt() и лишь после пытается метить сегмент флагом IPC_RMID. Попробовал
поменять порядок и вроде как заработало.
Если кто-то может его прокомментировать, welcome.
--
С уважением, Владимир Леттиев aka crux <crux@gorodmasterov.com>
[-- Attachment #2: sharelite.diff --]
[-- Type: text/x-patch, Size: 1029 bytes --]
--- sharelite.c~ 2000-04-14 14:24:00 +0400
+++ sharelite.c 2005-10-02 14:07:41 +0400
@@ -284,10 +284,10 @@
/* garbage collection -- remove unused segments */
if (node->shmaddr->next_shmid >= 0) {
shmid = node->shmaddr->next_shmid;
- if (_detach_segments(node->next) < 0)
- return -1;
if (_remove_segments(shmid) < 0)
return -1;
+ if (_detach_segments(node->next) < 0)
+ return -1;
node->shmaddr->next_shmid = -1;
node->next = NULL;
share->tail = node;
@@ -446,16 +446,18 @@
}
semid = share->head->shmid;
- if (_detach_segments(share->head) < 0)
- return -1;
if (rmid) {
if (_remove_segments(semid) < 0)
return -1;
semctl_arg.val = 0;
+ if (_detach_segments(share->head) < 0)
+ return -1;
if (semctl(share->semid, 0, IPC_RMID, semctl_arg) < 0)
return -1;
} else {
+ if (_detach_segments(share->head) < 0)
+ return -1;
if (RM_EX_LOCK(share->semid) < 0)
return -1;
}
next prev parent reply other threads:[~2005-10-02 10:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-29 19:08 [devel] " Alexey M. Tourbin
2005-09-29 20:28 ` Vladimir Lettiev
2005-09-30 15:35 ` Alexey Gladkov
2005-09-30 23:15 ` Vladimir Lettiev
2005-10-01 3:16 ` [devel] " Alexey Tourbin
2005-10-01 7:16 ` Vladimir Lettiev
2005-10-01 7:28 ` Alexey Tourbin
2005-10-01 16:01 ` Dmitry V. Levin
2005-10-01 20:22 ` [devel] [JT] 2.6-ow? Michael Shigorin
2005-10-02 10:19 ` Vladimir Lettiev [this message]
2005-10-03 15:40 ` [devel] Re: I: Sisyphus-20050929 unmets: +2 (93/40) Dmitry V. Levin
2005-10-03 19:03 ` Vladimir Lettiev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=433FB41B.7020804@gorodmasterov.com \
--to=crux@gorodmasterov.com \
--cc=devel@altlinux.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
ALT Linux Team development discussions
This inbox may be cloned and mirrored by anyone:
git clone --mirror http://lore.altlinux.org/devel/0 devel/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 devel devel/ http://lore.altlinux.org/devel \
devel@altlinux.org devel@altlinux.ru devel@lists.altlinux.org devel@lists.altlinux.ru devel@linux.iplabs.ru mandrake-russian@linuxteam.iplabs.ru sisyphus@linuxteam.iplabs.ru
public-inbox-index devel
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://lore.altlinux.org/org.altlinux.lists.devel
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git