From: Alexey Gladkov <legion@altlinux.ru> To: "Dmitry V. Levin" <ldv@altlinux.org> Cc: devel@lists.altlinux.org, "Vladimir D. Seleznev" <vseleznv@altlinux.org> Subject: Re: [devel] [PATCH v4 1/2] Add diff exclude option for gear-rules Date: Mon, 7 Dec 2020 18:29:13 +0100 Message-ID: <20201207172913.artgjib3dcyxtfv4@example.org> (raw) In-Reply-To: <20201207171925.GB13984@altlinux.org> On Mon, Dec 07, 2020 at 08:19:25PM +0300, Dmitry V. Levin wrote: > On Mon, Dec 07, 2020 at 06:07:41PM +0100, Alexey Gladkov wrote: > > On Mon, Dec 07, 2020 at 07:58:09PM +0300, Dmitry V. Levin wrote: > > > On Fri, Nov 27, 2020 at 04:44:30PM +0300, Vladimir D. Seleznev wrote: > [...] > > > > @@ -376,6 +376,13 @@ get_diff_name() > > > > ;; > > > > name=*) diff_name="${opt#name=}" > > > > ;; > > > > + exclude=*) > > > > + [ -z "$(printf %s "${opt#exclude=}" |tr -d '[:alnum:]_.?*-/![]')" ] || > > > > + rules_error "Invalid diff exclude pattern specified: ${opt#exclude=}" > > > > > > Why '[:alnum:]_.?*-/![]' ? > > > > because glob patterns have these symbols. > > This doesn't match the pattern check in extract_pattern(), > should it be updated? This is a different issue. I told you about this on November 26, 2020. > Would it be useful to have a single definition of this set somewhere? Yep. -- Rgrds, legion
next prev parent reply other threads:[~2020-12-07 17:29 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-27 13:44 Vladimir D. Seleznev 2020-11-27 13:44 ` [devel] [PATCH v4 2/2] tests: add test for diff exclude option Vladimir D. Seleznev 2020-12-07 14:30 ` [devel] [PATCH v4 1/2] Add diff exclude option for gear-rules Vladimir D. Seleznev 2020-12-07 16:58 ` Dmitry V. Levin 2020-12-07 17:07 ` Alexey Gladkov 2020-12-07 17:19 ` Dmitry V. Levin 2020-12-07 17:29 ` Alexey Gladkov [this message] 2020-12-07 17:57 ` Vladimir D. Seleznev
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201207172913.artgjib3dcyxtfv4@example.org \ --to=legion@altlinux.ru \ --cc=devel@lists.altlinux.org \ --cc=ldv@altlinux.org \ --cc=vseleznv@altlinux.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
ALT Linux Team development discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://lore.altlinux.org/devel/0 devel/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 devel devel/ http://lore.altlinux.org/devel \ devel@altlinux.org devel@altlinux.ru devel@lists.altlinux.org devel@lists.altlinux.ru devel@linux.iplabs.ru mandrake-russian@linuxteam.iplabs.ru sisyphus@linuxteam.iplabs.ru public-inbox-index devel Example config snippet for mirrors. Newsgroup available over NNTP: nntp://lore.altlinux.org/org.altlinux.lists.devel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git