From: "Dmitry V. Levin" <ldv@altlinux.org>
To: ALT Devel discussion list <devel@lists.altlinux.org>
Subject: Re: [devel] [PATCH] gb-task-check-noarch-i: check package scriptlets
Date: Mon, 27 Jul 2020 15:34:14 +0300
Message-ID: <20200727123414.GA17816@altlinux.org> (raw)
In-Reply-To: <20200721124024.2475221-1-vseleznv@altlinux.org>
On Tue, Jul 21, 2020 at 03:40:24PM +0300, Vladimir D. Seleznev wrote:
> noarch packages should have equal scriptlets across all arches.
> New function dump_scriptlets() prints content of RPM package scriptlets.
>
> * dump_scriptlets(): New function.
> * dump_noarch(): Use dump_scriptlets().
> * dump_arch(): Use dump_scriptlets().
>
> Reported-by: Ivan Zakharyaschev <imz@altlinux.org>
> ---
> gb/gb-task-check-noarch-i | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/gb/gb-task-check-noarch-i b/gb/gb-task-check-noarch-i
> index 2e38b6c..05ade0c 100755
> --- a/gb/gb-task-check-noarch-i
> +++ b/gb/gb-task-check-noarch-i
> @@ -79,10 +79,26 @@ dump_deps()
> rpmquery --qf "$R$P$O$C" -p "$1"
> }
>
> +dump_scriptlets()
> +{
> + for rpmtag in POSTIN POSTINPROG \
> + POSTUN POSTUNPROG \
> + PREIN PREINPROG \
> + PREUN PREUNPROG \
> + TRIGGERSCRIPTS TRIGGERSCRIPTPROG \
> + VERIFYSCRIPT VERIFYSCRIPTPROG
> + do
> + # print nicely formated scriptlet
> + rpmquery --qf "%{$rpmtag}\n" -p "$1" |sed '=' |
> + sed "s,^,${rpmtag}:,;N;s,\n, ,"
> + done
> +}
> +
> dump_noarch()
> {
> dump_rpmfile "$1"
> dump_deps "$1"
> + dump_scriptlets "$1"
> }
>
> set -- $GB_ARCH
> @@ -176,6 +192,7 @@ dump_arch()
> rpmquery --qf "$F" -p "$1" |
> LC_ALL=C grep -v '^/usr/share/' || [ $? -eq 1 ]
> dump_deps "$1"
> + dump_scriptlets "$1"
> }
>
> srcN=
Смержено в таком варианте:
http://git.altlinux.org/people/ldv/packages/?p=girar.git;a=commitdiff;h=62e87f04fc76d0f97d3fd80ce97c523b651786e2
--
ldv
prev parent reply other threads:[~2020-07-27 12:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 22:54 Vladimir D. Seleznev
2020-07-20 23:00 ` Vladimir D. Seleznev
2020-07-21 11:49 ` Dmitry V. Levin
2020-07-21 11:57 ` Vladimir D. Seleznev
2020-07-21 12:02 ` Dmitry V. Levin
2020-07-21 12:15 ` Vladimir D. Seleznev
2020-07-21 12:28 ` Dmitry V. Levin
2020-07-21 12:40 ` Vladimir D. Seleznev
2020-07-21 12:42 ` Vladimir D. Seleznev
2020-07-27 12:34 ` Dmitry V. Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200727123414.GA17816@altlinux.org \
--to=ldv@altlinux.org \
--cc=devel@lists.altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
ALT Linux Team development discussions
This inbox may be cloned and mirrored by anyone:
git clone --mirror http://lore.altlinux.org/devel/0 devel/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 devel devel/ http://lore.altlinux.org/devel \
devel@altlinux.org devel@altlinux.ru devel@lists.altlinux.org devel@lists.altlinux.ru devel@linux.iplabs.ru mandrake-russian@linuxteam.iplabs.ru sisyphus@linuxteam.iplabs.ru
public-inbox-index devel
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://lore.altlinux.org/org.altlinux.lists.devel
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git