From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 11 Dec 2019 01:45:00 +0300 From: "Dmitry V. Levin" To: ALT Devel discussion list Message-ID: <20191210224500.GC31774@altlinux.org> References: <20191210152343.33867-1-darktemplar@altlinux.org> <20191210152343.33867-3-darktemplar@altlinux.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="f+W+jCU1fRNres8c" Content-Disposition: inline In-Reply-To: <20191210152343.33867-3-darktemplar@altlinux.org> Subject: Re: [devel] [PATCH for apt 02/38] Use correct types and type specifiers X-BeenThere: devel@lists.altlinux.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: ALT Linux Team development discussions List-Id: ALT Linux Team development discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Dec 2019 22:45:00 -0000 Archived-At: List-Archive: List-Post: --f+W+jCU1fRNres8c Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 10, 2019 at 06:23:07PM +0300, Aleksei Nikiforov wrote: > Found via cppcheck > --- > apt/apt-pkg/contrib/cdromutl.cc | 4 ++-- > apt/apt-pkg/contrib/strutl.cc | 8 ++++---- > apt/cmdline/acqprogress.cc | 4 ++-- > apt/methods/connect.cc | 4 ++-- > apt/methods/http.cc | 9 +++------ > apt/methods/http.h | 2 +- > 6 files changed, 14 insertions(+), 17 deletions(-) It would be great if you included the cppcheck diagnostics as well, you can use the following commit as an example: https://gitlab.com/strace/strace/commit/2b64854e --=20 ldv --f+W+jCU1fRNres8c Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJd8B/sAAoJEAVFT+BVnCUILa4QAKIlb+i8LSxIkV+qXAPuY3ZE u6yVnwVON09QeFS4VMQ9c/fqbKWEXDJ0RxHBjbpVsIF41MzJATnCQzSt8xkvCdkl UCTZEVYr4u0qqPVFNQSGnMm4XEljGtk7js/S/gUqHnkQL0+s5Zq/6/6DvSDub7ly skiQ4LtPBPz1Mndv4fqMjRJbxk/zBAkmli9CKK3+Xfil9NQ3JnZ2NTLIdb5EK5Qg ueP0Ex7dtdOZU6CNiaxkYUuuWXQGnt0dHcszWMUN1kJMYMv0eU5GoV45l2bLh1Zx 6VAbXxxs34wO0MN9n32K7vuWUPD+QNOU+yNDw3gR3m1USUXuFZEl8N80A5zWbukJ xFaHiNezHkP5ZiQFJm8pjB8KOgA/FWVsKfx67z2A6BWwoB71tkKc05oebqkbH/fm 19/6n8EcWUCJDs55uKTHz27Ya7rnzfE5Z3TXwcnTdO+QzgEa3G+X3KU0nbLz85e3 2p3Bx+GCQzy95DiFkqI0xdNGIDc3oFb4ZnT78e7R2HWHqy47MjdPhO12AnxfgT3l yWty1TA6RPWhTTfkUTgBuCMegbtXrEexYqbyDPZIfO+48/m8JQPHqkI/Lq/xlxNS CpYjpZj6ZK3y+FGtD1E1btx4Vl7TAwgNJcU4fqDAnZrNWyZCru7wFtO6/+IozPeY 7Rj0yfNe2urxMTY0zfP2 =nbjo -----END PGP SIGNATURE----- --f+W+jCU1fRNres8c--