ALT Linux Team development discussions
 help / color / mirror / Atom feed
From: Aleksei Nikiforov <darktemplar@altlinux.org>
To: devel@lists.altlinux.org
Cc: Aleksei Nikiforov <darktemplar@altlinux.org>
Subject: [devel] [PATCH for rpm v3] Add triggers circumvension for packagekit offline update
Date: Tue,  5 Nov 2019 15:40:56 +0300
Message-ID: <20191105124055.9661-1-darktemplar@altlinux.org> (raw)
In-Reply-To: <20191101185842.GA7204@altlinux.org>

packagekit offline update is implemented in following way:
1) system is preparing for offline update:
   all new installed packages are downloaded, etc.
2) system is rebooting into special systemd offline update mode
   upon user request.
3) in this offline update mode packagekit offline update service is performing
   system update using packagekit service activated via dbus.
4) Last step of systemd offline update is a reboot request.
   It must be made by offline update service.
   And packagekit offline update service does request it.

Thus, rpmdb --rebuilddb from rpm scripts would be in race against reboot request.
Testing showed that it doesn't work properly in such conditions.
In best case, rpmdb --rebuilddb doesn't do anything at all before reboot happens.
Instead of hoping to get it work properly in such conditions,
disabling it in rpm scripts and calling it right after update
but before reboot request from packagekit offline update works fine.

Joint change with Oleg Solovyov (mcpain@)
---
 alt/rpm.spec | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/alt/rpm.spec b/alt/rpm.spec
index 6217493b7..a38367ffd 100644
--- a/alt/rpm.spec
+++ b/alt/rpm.spec
@@ -385,6 +385,10 @@ ls -A tests/rpmtests.dir 2>/dev/null ||:
 #[ ! -L %%_rpmlibdir/noarch-alt-%%_target_os ] || rm -f %%_rpmlibdir/noarch-alt-%%_target_os ||:
 
 %post
+if [ -f %_localstatedir/PackageKit/disable-rpm-triggers ]; then
+        exit 0
+fi
+
 #chgrp %%name %%_localstatedir/%%name/[A-Z]*
 [ -n "$DURING_INSTALL" -o -n "$BTE_INSTALL" ] ||
         %_rpmlibdir/pdeath_execute $PPID %_rpmlibdir/postupdate
-- 
2.21.0



  reply	other threads:[~2019-11-05 12:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-31 11:58 [devel] [PATCH for rpm] " Aleksei Nikiforov
2019-10-31 12:59 ` Dmitry V. Levin
2019-10-31 13:19   ` Aleksei Nikiforov
2019-11-01 18:58     ` Dmitry V. Levin
2019-11-05 12:40       ` Aleksei Nikiforov [this message]
2019-10-31 13:24   ` [devel] [PATCH for rpm v2] " Aleksei Nikiforov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191105124055.9661-1-darktemplar@altlinux.org \
    --to=darktemplar@altlinux.org \
    --cc=devel@lists.altlinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

ALT Linux Team development discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://lore.altlinux.org/devel/0 devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 devel devel/ http://lore.altlinux.org/devel \
		devel@altlinux.org devel@altlinux.ru devel@lists.altlinux.org devel@lists.altlinux.ru devel@linux.iplabs.ru mandrake-russian@linuxteam.iplabs.ru sisyphus@linuxteam.iplabs.ru
	public-inbox-index devel

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://lore.altlinux.org/org.altlinux.lists.devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git