ALT Linux Team development discussions
 help / color / mirror / Atom feed
From: Alexey Tourbin <at@altlinux.ru>
To: devel@altlinux.ru
Subject: [devel] Re: Q: snprintf
Date: Mon, 22 Mar 2004 19:21:19 +0300
Message-ID: <20040322162119.GQ27221@solemn.turbinal.org> (raw)
In-Reply-To: <20040322035312.GB4651@sam-solutions.net> <20040321193923.GN27221@solemn.turbinal.org>

[-- Attachment #1: Type: text/plain, Size: 1217 bytes --]

On Mon, Mar 22, 2004 at 05:53:12AM +0200, Alexander Bokovoy wrote:
> > Нижеследующий кусок (одного патча) меня озадачил.  Существует ли
> > надежный способ определить: была ли переменная объявлена как имя
> > массива, или как указатель?
> В каком языке? В C?

Да.  Вот смотри:

On Sun, Mar 21, 2004 at 10:39:23PM +0300, Alexey Tourbin wrote:
> --- src/lvm.c.orig     2004-01-13 11:37:53.000000000 -0200
> +++ src/lvm.c  2004-01-13 11:33:34.000000000 -0200
> @@ -32,7 +32,7 @@
> 
>  /* function to convert a lua_Number to a string */
>  #ifndef lua_number2str
> -#define lua_number2str(s,n)     sprintf((s), LUA_NUMBER_FMT, (n))
> +#define lua_number2str(s,n)     snprintf((s), sizeof((s)), LUA_NUMBER_FMT, (n))
>  #endif
> 

Т.е. есть кусок некоторого API, которое broken by design, но его
кому-то хочется зафиксить.  Но в данном случае использование sizeof
в макросе некорректно, т.к. переменная s может быть указателем, а не
именем массива, а размер любого указателя всегда равен sizeof(long).

Пока приходит в голову только следующее:

#define lua_number2str(s,n)	(sizeof(s) > sizeof(char*)) ? \
	snprintf((s), sizeof((s)), LUA_NUMBER_FMT, (n)) : \
	sprintf((s), LUA_NUMBER_FMT, (n))

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2004-03-22 16:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-21 19:39 [devel] " Alexey Tourbin
2004-03-22  3:53 ` Alexander Bokovoy
2004-03-22 16:21   ` Alexey Tourbin [this message]
2004-03-22 16:24     ` [devel] " Alexander Bokovoy
2004-03-23  0:01       ` Alexey Tourbin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040322162119.GQ27221@solemn.turbinal.org \
    --to=at@altlinux.ru \
    --cc=devel@altlinux.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

ALT Linux Team development discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://lore.altlinux.org/devel/0 devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 devel devel/ http://lore.altlinux.org/devel \
		devel@altlinux.org devel@altlinux.ru devel@lists.altlinux.org devel@lists.altlinux.ru devel@linux.iplabs.ru mandrake-russian@linuxteam.iplabs.ru sisyphus@linuxteam.iplabs.ru
	public-inbox-index devel

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://lore.altlinux.org/org.altlinux.lists.devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git