From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on sa.local.altlinux.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=unavailable autolearn_force=no version=3.4.1 From: kovalev@altlinux.org To: devel-kernel@lists.altlinux.org Date: Thu, 7 Mar 2024 11:50:42 +0300 Message-Id: <20240307085042.497233-3-kovalev@altlinux.org> X-Mailer: git-send-email 2.33.8 In-Reply-To: <20240307085042.497233-1-kovalev@altlinux.org> References: <20240307085042.497233-1-kovalev@altlinux.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [d-kernel] [PATCH 2/2] ASoC: codecs: fix warning for the es8316 codec build (ALT) X-BeenThere: devel-kernel@lists.altlinux.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: ALT Linux kernel packages development List-Id: ALT Linux kernel packages development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Mar 2024 08:52:16 -0000 Archived-At: List-Archive: List-Post: From: Vasiliy Kovalev sound/soc/codecs/es8316.c:517:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] 517 | static u8 only_one = 0; | ^~~~~~ Fixes: f63b2a193575f82 ("ASoC: AMD: add ACP machine driver for ES8336") Signed-off-by: Vasiliy Kovalev --- sound/soc/codecs/es8316.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/es8316.c b/sound/soc/codecs/es8316.c index f6e3f0e7e56583..621084fbc87708 100644 --- a/sound/soc/codecs/es8316.c +++ b/sound/soc/codecs/es8316.c @@ -460,6 +460,8 @@ static int es8316_pcm_startup(struct snd_pcm_substream *substream, return 0; } +static u8 static_flag; + static int es8316_pcm_hw_params(struct snd_pcm_substream *substream, struct snd_pcm_hw_params *params, struct snd_soc_dai *dai) @@ -513,9 +515,8 @@ static int es8316_pcm_hw_params(struct snd_pcm_substream *substream, return -EINVAL; } - static u8 only_one = 0; - if (!only_one) { - only_one = 1; + if (!static_flag) { + static_flag = 1; if (mclk_div == 2) dev_info(component->dev, "Activating MCLK div by 2\n"); -- 2.33.8