ALT Linux kernel packages development
 help / color / mirror / Atom feed
From: nickel@altlinux.org
To: devel-kernel@lists.altlinux.org
Cc: Sergey Ivanov <zagagyka@basealt.ru>
Subject: [d-kernel] [PATCH 2/3] Revert "Input: clear BTN_RIGHT/MIDDLE on buttonpads"
Date: Thu, 24 Mar 2022 10:51:24 +0300
Message-ID: <20220324075125.997745-3-nickel@altlinux.org> (raw)
In-Reply-To: <20220324075125.997745-1-nickel@altlinux.org>

From: Nikolai Kostrigin <nickel@altlinux.org>

This commit breaks touchpad right button operation on ICL Si1516 laptop

Refer to ALT#42123

This reverts commit 6279c5263dedc6af67c194ec8e0f91bc2849cdf8.

Reported-by: Sergey Ivanov <zagagyka@basealt.ru>
Signed-off-by: Nikolai Kostrigin <nickel@altlinux.org>
---
 drivers/input/input.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/input/input.c b/drivers/input/input.c
index c3139bc2aa0d..ccaeb2426385 100644
--- a/drivers/input/input.c
+++ b/drivers/input/input.c
@@ -2285,12 +2285,6 @@ int input_register_device(struct input_dev *dev)
 	/* KEY_RESERVED is not supposed to be transmitted to userspace. */
 	__clear_bit(KEY_RESERVED, dev->keybit);
 
-	/* Buttonpads should not map BTN_RIGHT and/or BTN_MIDDLE. */
-	if (test_bit(INPUT_PROP_BUTTONPAD, dev->propbit)) {
-		__clear_bit(BTN_RIGHT, dev->keybit);
-		__clear_bit(BTN_MIDDLE, dev->keybit);
-	}
-
 	/* Make sure that bitmasks not mentioned in dev->evbit are clean. */
 	input_cleanse_bitmasks(dev);
 
-- 
2.33.0



  parent reply	other threads:[~2022-03-24  7:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-24  7:51 [d-kernel] [PATCH 0/3] *** Backport latest changes from Sisyphus to p10 for un-def *** nickel
2022-03-24  7:51 ` [d-kernel] [PATCH 1/3] config: enable Atheros ath11k PCI support nickel
2022-03-24  7:51 ` nickel [this message]
2022-03-24  8:16   ` [d-kernel] [PATCH 2/3] Revert "Input: clear BTN_RIGHT/MIDDLE on buttonpads" Vitaly Chikunov
2022-03-24  8:57     ` Nikolai Kostrigin
2022-03-24  9:26       ` Vitaly Chikunov
2022-03-29 14:55         ` Dmitry V. Levin
2022-03-29 15:06           ` Nikolai Kostrigin
2022-04-05 10:22             ` Nikolai Kostrigin
2022-03-24  7:51 ` [d-kernel] [PATCH 3/3] config: enable MediaTek Bluetooth USB controllers support nickel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220324075125.997745-3-nickel@altlinux.org \
    --to=nickel@altlinux.org \
    --cc=devel-kernel@lists.altlinux.org \
    --cc=zagagyka@basealt.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

ALT Linux kernel packages development

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://lore.altlinux.org/devel-kernel/0 devel-kernel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 devel-kernel devel-kernel/ http://lore.altlinux.org/devel-kernel \
		devel-kernel@altlinux.org devel-kernel@altlinux.ru devel-kernel@altlinux.com
	public-inbox-index devel-kernel

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://lore.altlinux.org/org.altlinux.lists.devel-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git